Skip to content

Add native <search> and <slot> tags - #3313

Open
LuLaValva wants to merge 1 commit into
mainfrom
add-search-slot-native-tags
Open

Add native <search> and <slot> tags#3313
LuLaValva wants to merge 1 commit into
mainfrom
add-search-slot-native-tags

Conversation

@LuLaValva

@LuLaValva LuLaValva commented Jun 29, 2026

Copy link
Copy Markdown
Member

Adds the native <search> and <slot> HTML elements to the taglib and tags-html.d.ts type definitions.

Generated by Claude Code

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 622cbc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/runtime-tags Patch
marko Patch
@marko/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva changed the title Add native &lt;search&gt; and &lt;slot&gt; tags Add native <search> and <slot> tags Jun 29, 2026
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5189ca20-9ef8-4782-9b46-047e54501a49

📥 Commits

Reviewing files that changed from the base of the PR and between 0f6ac28 and 622cbc5.

📒 Files selected for processing (5)
  • .changeset/add-search-slot-native-tags.md
  • packages/compiler/src/taglib/marko-html.json
  • packages/runtime-class/tags-html.d.ts
  • packages/runtime-class/test/taglib-lookup/fixtures/getTagsSorted/expected.json
  • packages/runtime-tags/tags-html.d.ts

Walkthrough

Two native HTML tags, <search> and <slot>, are added to the compiler's marko-html.json taglib. Both are marked as html: true with the html-attributes attribute group; <slot> also includes a name attribute. Corresponding Marko.HTML.Search interfaces and Marko.NativeTags.search entries are added to tags-html.d.ts in both runtime-class and runtime-tags packages. A test fixture for sorted tag lookup is updated to include the two new tags, and a patch changeset entry is added.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding native and tags.
Description check ✅ Passed The description directly matches the changeset by describing the new native and HTML elements in taglib and typings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-search-slot-native-tags

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.29%. Comparing base (0f6ac28) to head (622cbc5).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3313   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         383      383           
  Lines       51311    51311           
  Branches     3961     3961           
=======================================
  Hits        48386    48386           
  Misses       2899     2899           
  Partials       26       26

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LuLaValva